Review Request: 8005347: build-infra: Verify 'gnumake source' at the top level works ok
kelly.ohair at oracle.com
Tue Jan 1 17:36:32 UTC 2013
Is it just me, or is this m4 stuff hard to review with plain diffs. :^(
One of these days someone will come up with a difference tool that takes into account the type
of file it is and stop treating all files as simple text files.
Has anyone ever tried http://www.guiffy.com/?
On Jan 1, 2013, at 6:39 AM, Erik Joelsson wrote:
> New webrev. I decided that David was right, it really should be in closed so I moved it there, along with the closed version numbers file and the reading of it. These files are also changing names slightly to avoid the .numbers extension which is just weird.
> On 2012-12-31 11:01, Erik Joelsson wrote:
>> No, they are not. I hesitated as to if I should move it all to closed, but opted not to at this point, to save time more than anything. Ok if I open a bug on moving it to fix it later?
>> On 2012-12-30 23:45, David Holmes wrote:
>>> On 30/12/2012 11:51 PM, Erik Joelsson wrote:
>>>> Open part of this review. Configure needs to supply a couple of more
>>>> utilities and version string variations.
>>> Those new variables do not seem relevant to openjdk builds. Is any of this "gnumake source" relevant to openjdk builds ??
More information about the build-dev