Review Request: 8005347: build-infra: Verify 'gnumake source' at the top level works ok
david.holmes at oracle.com
Tue Jan 1 22:58:53 UTC 2013
Not sure of how all the bits click together between open and closed but
on the surface this looks okay.
One nit. The old version number file had a copyright
Copyright (c) 2012,
yet somehow the new one became
Copyright (c) 2011, 2012,
Really I think it should now be:
Copyright (c) 2012, 2013,
On 2/01/2013 12:39 AM, Erik Joelsson wrote:
> New webrev. I decided that David was right, it really should be in
> closed so I moved it there, along with the closed version numbers file
> and the reading of it. These files are also changing names slightly to
> avoid the .numbers extension which is just weird.
> On 2012-12-31 11:01, Erik Joelsson wrote:
>> No, they are not. I hesitated as to if I should move it all to closed,
>> but opted not to at this point, to save time more than anything. Ok if
>> I open a bug on moving it to fix it later?
>> On 2012-12-30 23:45, David Holmes wrote:
>>> On 30/12/2012 11:51 PM, Erik Joelsson wrote:
>>>> Open part of this review. Configure needs to supply a couple of more
>>>> utilities and version string variations.
>>> Those new variables do not seem relevant to openjdk builds. Is any of
>>> this "gnumake source" relevant to openjdk builds ??
More information about the build-dev