Review Request: 8005635: build-infra: Support building install in jprt
david.holmes at oracle.com
Thu Jan 3 11:59:57 UTC 2013
Not sure about this one. Why do the image directories need to be
configure time variables placed in spec.gmk? For profiles I dynamically
change JRE_IMAGE_DIR based on the profile being built. I don't think
this change breaks that because I set it as a make variable on the
submake invocation. But the fact that you need to do this indicates
there is something that may conflict with what I am doing.
On 3/01/2013 9:36 PM, Erik Joelsson wrote:
> One more variable being converted for jprt.
> On 2013-01-02 19:34, Erik Joelsson wrote:
>> Missed the changes to common/makefiles/Jprt.gmk. New webrev:
>> On 2013-01-02 17:14, Erik Joelsson wrote:
>>> This is the open part of this review. The changes are mostly
>>> concerning compare logic and introducing a couple of new variables in
>>> spec for images directories.
>>> Contributed by Tim Bell and myself.
More information about the build-dev