Review request: 8005096: Move a few source files in swing/beaninfo and in a demo.
oehrstroem at gmail.com
Mon Jan 7 15:59:00 UTC 2013
2012/12/18 Sergey Malenkov <Sergey.Malenkov at oracle.com>:
> Looks OK to me. But there are a lot of images in the
> make/tools/swing-beans/beaninfo/images folder. Could you please check the
> make/javax/swing/beaninfo/SwingBeans.gmk file to ensure that the dt.jar
> library will be packed correctly?
Yes, I have verified that the gifs are in the same folder.
> Also I think that moving of java files from the
> make/tools/swing-beans/beaninfo folder is redundant, because we could copy
> them to the expected folder from the current location.
Yes, copying to a temporary, correct package directory, would work. But I think
it is better to move them into the correct package directory, it is simpler
However here is another question. With this change,
the following 46 source files appear in src.zip:
---- 8< ----
It seems to be reasonable that these sources should be part of the
src.zip and that it was a bug previously that they were not.
Can you confirm this Sergey?
More information about the build-dev