RFR : 8006594/8006595 : Define jdk_core test set

Alan Bateman Alan.Bateman at oracle.com
Wed Jan 23 14:35:07 UTC 2013

On 22/01/2013 21:15, Mike Duigou wrote:
> Hello all;
> This is a two piece patch.
> 8006594: Add jdk_core target to jdk/test/Makefile
> 8006595: Use jdk/test/Makefile targets in preference to local definitions
> I chose to do it as two patches because the changes are in different repos and the changes in 8006594 could be committed without the 8006595 changes.
> The webrevs are:
> http://cr.openjdk.java.net/~mduigou/8006594/0/webrev/
The changes in this one look okay to me but doesn't it mean that not all 
targets will be run if there is a test failure? For example, if a test 
in the jdk_lang target failures then I assume this will cause make to 
abort and none of the other test targets will run.

The other thing that is that I assume this means the results are in 
scattered locations where I would think that anyone doing "make test 
TEST=jdk_core" would expect to get one set of results. As an aside, I 
personally prefer to run jtreg directly and I keep a "core.list" with 
the exploded list of directories that corresponds to jdk_core in this 
webrev. The nice thing about it is that it is one jtreg run so all the 
results in together and easily browsed. You mentioned that this is the 
in a series of patches so you might be looking into moving in that 
direction too.
> http://cr.openjdk.java.net/~mduigou/8006595/0/webrev/
The comment on L83 says "everything", maybe that should be updated (it 
was wrong before your change too). Otherwise I think this is okay. It's 
a pity that we have the list of targets in so many places, it's so easy 
to have mis-matches.

You mentioned pushing this via jdk8/build but it's probably okay to push 
it via jdk8/tl because the build doesn't care about the test Makefiles.


More information about the build-dev mailing list