Code Review Request: Simple new build system fix
erik.joelsson at oracle.com
Wed Mar 13 13:37:32 UTC 2013
I created a bug for you:
8009988: build-infra: Fix configure output for zip debuginfo check
As David says, we haven't decided on 2.67, but I would guess that a
majority of the commits have been with that version. This change is a
first step towards enforcing a specific version and I'm ok with that.
The actual fix looks good to. You will still need a JDK reviewer to ok
it. Also, please notify me when you push this so that the closed version
of the configure script may also be regenerated.
On 2013-03-13 13:18, Andrew Hughes wrote:
> I've finally found time to look at the new build system (well, there seems to no longer be any choice ;)
> and so thought I start out with a simple fix.
> At the moment, if disable-zip-debug-info is not specified, the configure output is:
> checking if we should zip debug-info files...
> with no result as $enable_zip_debug_info is unset.
> This simple patch makes the option use the more standard AC_ARG_ENABLE form used elsewhere and will
> print the default ('yes') when the option is unspecified:
> checking if we should zip debug-info files... yes
> What actually took longer than the fix was updating the generated files. We seem to have already settled
> on autoconf 2.67 for generating the configure script, so my initial attempt threw up a huge number of changes
> as the system install is 2.69. I was able to get it down to something closer to what is expected by installing
> a local copy of 2.67 but it's still not perfect. I don't know why. I've never been a fan of including generated
> files for this reason.
> So this script also updates autogen.sh to see if there is an autoconf-2.67 available and use that in preference
> to autoconf if it is. I also added a little debug output so we can see which autoconf is being used in autogen.sh.
> If this is ok, can you please allocate it a bug ID and let me know which tree to commit it to.
More information about the build-dev