RFR: 8009426 "profiles" target fails due to nashorn if "images" is not built first

David Holmes david.holmes at oracle.com
Tue Mar 19 09:10:17 UTC 2013

Hi Alan,

On 19/03/2013 5:44 PM, Alan Bateman wrote:
> On 18/03/2013 19:59, David Holmes wrote:
>> Very simple fix/cleanup.
>> webrev: http://cr.openjdk.java.net/~dholmes/8009426/webrev/
>> nashorn.jar was being added to the set of JARS targets regardless of
>> what was being built, but nashorn is not a dependency for profiles
>> target. JARS is not used the way it used to be now we have profiles
>> and all jar files should simply be listed in the appropriate entry in
>> profiles-includes.txt. There was a couple of other misplaced items too:
>> makefiles/CreateJars.gmk
>>   Removed nashorn and tzdb setting of JARS
>> makefiles/Profiles.gmk
>>   Removed redundant listing of cldrdata.jar
>> makefiles/profile-includes.txt
>>   Add nashorn to full JRE lists
> This looks okay to me for now but as javax.script is in compact3 then we
> should be looking to include that in the compact3 builds.

If we are definitely going to add nashorn.jar to compact3 then I will 
revise this to do so, and add the missing dependency to ensure nashorn 
is built. If this decision still has to be confirmed then I will push 
what I have now and we can deal with the change later.


> The other clean-ups looks okay to me too. I remember suggesting to
> Sherman to add tzdb.jar to JARS but that was prior to the merge with
> profiles (pre-dated profiles-includes.txt).
> -Alan.

More information about the build-dev mailing list