RFR: 8009824: webrev.ksh generated jdk.patch files do not handle renames, copies, and shouldn't be applied

Mike Duigou mike.duigou at oracle.com
Wed Mar 27 17:02:59 UTC 2013

I've generated a couple of webrevs using your updated version. It's definitely an improvement.

When I made my updates I didn't change the version number "23.18" but instead just added "+jbs". I do think we should decide what to do regarding versioning especially since webrev writes it's version to the output files. Time for "24.0"?


On Mar 26 2013, at 10:50 , Jim Gish wrote:

> Please review http://cr.openjdk.java.net/~jgish/Bug8009824-UpdateWebrevToUseHgExport/ <http://cr.openjdk.java.net/%7Ejgish/Bug8009824-UpdateWebrevToUseHgExport/>
> This change to webrev.ksh replaces the current method for generating a patch with one that uses hg export -g, preserving copy, move and rename operations.  The current method results in a patch which does not properly account for these file operations and cannot be safely applied.
> As a result of this change, a valid changeset is generated that can be safely applied by a committer (reducing the burden on and decreasing the chance of mistakes by non-committers when preparing webrevs and subsequent changesets to be sent to committers for pushing).
> Note that the new method can only be used when there are committed changes.  If webrev is used against uncommitted changes in a users workspace, the old method of generating the patch is still used. (Another bug, another day :-))
> Thanks,
>   Jim

More information about the build-dev mailing list