Please review changes for JDK-8012975: Remove rhino from jdk8
sundararajan.athijegannathan at oracle.com
Fri May 3 06:47:50 UTC 2013
On Friday 03 May 2013 11:53 AM, Tim Bell wrote:
> On 05/ 2/13 01:24 PM, I wrote:
>> Hi Sundar:
>>> Oracle JDK includes Rhino based javax.script implementation (which
>>> lives mostly in "closed" code). Rhino is being removed from Oracle
>>> JDK builds and there are the changes to the jdk open repository as
>>> review the open jdk changes here:
>> This looks good. Approved.
> Sundar - we have had some breakage in the build forest recently, so to
> be extra careful I created a forest and then added your changes. I
> also did some blasting away with 'find ... -print | xargs egrep ...'
> I think you need to look at removing these files as well:
Thanks. Looks like the first one has not been removed. But second one
was removed: hg stat shows
(also the webrev shows it as removed). Perhaps patch does not take care
of deleted files?? I am not sure. Also, build seems to go through
without removing first one!!
I'll remove that, build/test again and send another webrev.
More information about the build-dev