RFR [9] 8039362: Read content-types.properties as a resource

Alan Bateman Alan.Bateman at oracle.com
Tue Apr 8 10:32:59 UTC 2014

On 07/04/2014 19:54, Chris Hegarty wrote:
> [ Including Alex; there is a question/confirmation related to a change he pushed, that needs his input ]
> Hi Erik,  thanks for your feedback, comments inline…
> Updated webrev:
>    http://cr.openjdk.java.net/~chegar/8039362/01/webrev/
Looks like JDK-7153735 was reviewed on macosx-port-dev which might how 
it went in without wider review.

I looked through the updated webrev and it looks okay to me. I guess I 
have a preference for "in" rather than "is" in MimeTable but is a minor 
comment. I agree with Mandy about using try-with-resources around the 
load as it this would leave the file open for the case that the property 
is set and the load fails for some reason.


More information about the build-dev mailing list