RFR: 8039411 : Add environment variable support to fixpath

Mike Duigou mike.duigou at oracle.com
Wed Apr 9 15:01:47 UTC 2014

On Apr 8 2014, at 03:43 , Dave Pointon <dpointo8 at linux.vnet.ibm.com> wrote:

> On Mon, 2014-04-07 at 14:53 -0700, Mike Duigou wrote:
>> Hello all;
>> http://cr.openjdk.java.net/~mduigou/JDK-8039411/0/webrev/
>> Mike
> Hiya Mike ,
> My, you _were_ busy :-)
> Given that I'm not formally a reviewer, nor indeed, author, I thought
> you might be interested in the following observations ...

I prefer an expert over a title any day of the week. :-)

> * I wonder if it would not be better (more readable) to utilise one of
> the POSIX standard string comparison library functions e.g. strcmp() or
> strncmp(),  within the function body - matching the prototype update
> that you made.
> * The replacement of strcpy() by memmove() isn't clear to me in
> replace_cygdrive_cygwin()

Both of these changes are to silence warnings from Visual Studio about use of string functions without explicit sizing.

Since this code is Windows specific I've preferred the Windows library functions over the similar C Standard Library functions. I probably should have gone all the way and converted malloc to LocalAlloc, etc.


More information about the build-dev mailing list