RFR: 8047952 : (s) Remove FORTIFY_SOURCE from fastdebug and slowdebug builds
mike.duigou at oracle.com
Mon Aug 11 23:09:26 UTC 2014
You are correct. The release and fastdebug need to be combined into one clause. I will fix this. Bash 4.0 doesn't appear to complain about the fallthrough but better to be compliant.
On Aug 11 2014, at 15:05 , Kim Barrett <kim.barrett at oracle.com> wrote:
> On Aug 8, 2014, at 8:23 PM, Mike Duigou <mike.duigou at oracle.com> wrote:
>> Hello all;
>> A previous version of this changeset was focused on disabling FORTIFY_SOURCE only for specific files with optimization disabled. This version entirely disables FORTIFY_SOURCE for all portions of the build. After additional problems; incompatibility of FORTIFY_SOURCE with -O0, lack of consistent support for FORTIFY_SOURCE in some distributions of glibc, etc. this seems like the best course. Should the separate issues with -Od be resolved then FORTIFY_SOURCE could be re-enabled selectively for specific platforms.
>> webrev: http://cr.openjdk.java.net/~mduigou/JDK-8047952/1/webrev/
>> jbsbug: https://bugs.openjdk.java.net/browse/JDK-8047952
> In common/autoconf/flags.m4:
> 339 if test "x$TOOLCHAIN_TYPE" = xgcc; then
> 340 case $DEBUG_LEVEL in
> 341 release )
> 342 fastdebug )
> 343 # no adjustment
> 344 ;;
> The bash documentation I'm looking at says each clause must end with
> ";;", and makes no mention of any sort of fall-through from one clause
> to the next.
> "... the ')' operator terminates a pattern list. A list of patterns
> and an associated command-list is known as a clause. Each clause
> must be terminated with ';;'"
> It's not clear from that description what should happen for line 341.
More information about the build-dev