RFR: 8047952 : (s) Remove FORTIFY_SOURCE from fastdebug and slowdebug builds
pointo1d at gmail.com
Tue Aug 12 13:11:34 UTC 2014
Hiya Mike ,
On 09/08/14 01:23, Mike Duigou wrote:
> Hello all;
> A previous version of this changeset was focused on disabling FORTIFY_SOURCE only for specific files with optimization disabled. This version entirely disables FORTIFY_SOURCE for all portions of the build. After additional problems; incompatibility of FORTIFY_SOURCE with -O0, lack of consistent support for FORTIFY_SOURCE in some distributions of glibc, etc. this seems like the best course. Should the separate issues with -Od be resolved then FORTIFY_SOURCE could be re-enabled selectively for specific platforms.
> webrev: http://cr.openjdk.java.net/~mduigou/JDK-8047952/1/webrev/
> jbsbug: https://bugs.openjdk.java.net/browse/JDK-8047952
FWIW, in addition to the other favourable responses, your changes look
fine to this non-reviewer.
Dave Pointon FIAP MBCS - Contractor engaged by IBM
Now I saw, tho' too late, the folly of beginning a work before we count the cost and before we we judge rightly of our strength to go thro' with it - Robinson Crusoe
More information about the build-dev