Review request: 8055856: checkdeps build target doesn't work for cross-compilation builds
Magnus Ihse Bursie
magnus.ihse.bursie at oracle.com
Wed Aug 27 10:19:47 UTC 2014
On 2014-08-27 10:26, Erik Joelsson wrote:
> Hello Mandy,
> Looking at this, I just realized that
> is a generated resource for a module and that you correctly added it
> to the gendata target. Then to make it fit with the new makefile
> model, the running of TOOL_GENMODULESXML should be moved to
> jdk/make/gendata/Gendata-jdk.dev.gmk, which would make it be run
> automatically with correct dependencies. ModulesXml.gmk should also
> probably be renamed to something better describing the checkdeps
> target, which is all it would be doing then. Perhaps it would also fit
> better in the root make dir.
> I can understand if fixing the cross compilation issue is urgent and
> am fine with you pushing this to fix that, but would like to see it
> further improved eventually.
I agree. The changes look good, but as Erik suggests, they can be taken
even further, possibly in a separate fix. Perhaps the name
"CheckModules.gmk" would be better suite than ModulesXml.gmk, when the
gendata part has been separated out?
More information about the build-dev