Review request: 8055856: checkdeps build target doesn't work for cross-compilation builds

Mandy Chung mandy.chung at
Thu Aug 28 17:16:39 UTC 2014

On 8/28/14 1:32 AM, Magnus Ihse Bursie wrote:
> On 2014-08-27 18:00, Mandy Chung wrote:
>> Erik, Magnus,
>> This is much easier than I have thought.  I really like this new build.
> Glad to hear! :)
>> I have separated out and removed the modules-xml
>> target completely.
>> Webrev at:
> Looks good, but I still think the CheckModules.gmk file should be in 
> $TOP/make/ instead of jdk/make. As a rule of thumb, stuff working on 
> "all modules" should sit in the top level, but stuff working on a 
> specific module should sit close to that module. Apart from that, it 
> looks great.

Agree.  It should be moved to the top repo. jdk/make/ModulesXml.gmk was 
added while the modular build was undergoing various change/reorganized.

I will move it.

More information about the build-dev mailing list