RFR(S): 8056246 : Fix AIX build after the Modular Source Code change 8054834
erik.joelsson at oracle.com
Fri Aug 29 07:22:15 UTC 2014
On 2014-08-28 18:24, Volker Simonis wrote:
>> This looks safe, but it's not clear why it needs to be done so it certainly
>> warrants a comment. Another approach on this would be to find a different
>> way of expressing FIND_DELETE on AIX that works better. Perhaps an xargs
>> construct? FIND_DELETE is defined in basics.m4 if you would want to give it
>> a shot.
> I already thought about this possibility, but then again, AIX
> find/xargs don't support "-print0"/"-O" which is considered a little
> unsafe (see for example
> What do you think, change it to xargs on AIX nevertheless or just add
> a comment to the current version?
So the problem is that an xargs variant would not support spaces in
filenames. Configure already fails before the first printout if there
are spaces in the path to the root repo so that shouldn't be an issue. I
very much doubt we would make an effort to support that use case. The
drawback of the current solution is that if we introduce a new use of
FIND_DELETE, we will most likely forget about the error if the find
returns nothing and you will have to fix it again for AIX. I'm fine with
either solution and will happily leave it for you to decide.
I took your patch and ran it through JPRT successfully so it has been
tried on all our platforms.
More information about the build-dev