RFR(S): 8056246 : Fix AIX build after the Modular Source Code change 8054834
erik.joelsson at oracle.com
Fri Aug 29 09:40:59 UTC 2014
Looks good. I will push it for you.
On 2014-08-29 11:06, Volker Simonis wrote:
> On Fri, Aug 29, 2014 at 9:22 AM, Erik Joelsson <erik.joelsson at oracle.com> wrote:
>> On 2014-08-28 18:24, Volker Simonis wrote:
>>>> This looks safe, but it's not clear why it needs to be done so it
>>>> warrants a comment. Another approach on this would be to find a different
>>>> way of expressing FIND_DELETE on AIX that works better. Perhaps an xargs
>>>> construct? FIND_DELETE is defined in basics.m4 if you would want to give
>>>> a shot.
>>> I already thought about this possibility, but then again, AIX
>>> find/xargs don't support "-print0"/"-O" which is considered a little
>>> unsafe (see for example
>>> What do you think, change it to xargs on AIX nevertheless or just add
>>> a comment to the current version?
>> So the problem is that an xargs variant would not support spaces in
>> filenames. Configure already fails before the first printout if there are
>> spaces in the path to the root repo so that shouldn't be an issue. I very
>> much doubt we would make an effort to support that use case. The drawback of
>> the current solution is that if we introduce a new use of FIND_DELETE, we
>> will most likely forget about the error if the find returns nothing and you
>> will have to fix it again for AIX. I'm fine with either solution and will
>> happily leave it for you to decide.
> OK, I thought about this all night long :) and came to the same
> conclusion - we should never ever support spaces in files on AIX!
> So here's a revised version of my patch:
> where I simply removed the changes to Rmic-java.management.gmk
> OK to push?
> Of course I will now need your help to review (and push, because it
> requires the regeneration of generated-configure.sh) the following
> tiny top-level change which sets FIND_DELETE to "-print | xargs rm" on
>> I took your patch and ran it through JPRT successfully so it has been tried
>> on all our platforms.
> Thanks a lot,
More information about the build-dev