RFR(XS): 8066589: Make importing sa-jdi.jar optional on its existance

Erik Joelsson erik.joelsson at oracle.com
Fri Dec 5 09:11:15 UTC 2014

Hello Volker,

Are these the only conditions for when sa-jdi.jar is not built? If so, 
then I suppose this is fine.

The old Import.gmk would only copy sa-jdi.jar if it existed, and I think 
we can keep that behavior, so just an existence check on sa-jdi.jar is 
good enough in Import.gmk. In Gensrc-jdk.jdi.gmk, checking if 
$(SUPPORT_OUTPUTDIR)/gensrc/jdk.hotspot.agent/_the.sa.services exists 
should be fine with me. We lose a bit of error checking in the build 
doing it that way as we won't fail if that file is missing for other 

Note that this hacking of the service provider files is a temporary hack 
until service providers are properly handled in the modular world, so no 
need for fancy solutions.


On 2014-12-04 18:49, Volker Simonis wrote:
> Hi,
> could you please review this tiny change which fixes the build on
> platforms which don't built the SA agent after the recent modualrity
> integrations:
> http://cr.openjdk.java.net/~simonis/webrevs/8066589
> https://bugs.openjdk.java.net/browse/JDK-8066589
> I've tested that the fix works on AIX but I havn't had a chance to build Zero.
> @Xerxes: maybe you could check if my suggested fix also solves your
> build problems. I'm also no sure if the "ifneq ($(JVM_VARIANT_ZERO),
> true)" clause also catches the ZEROSHARK case (altough I think it
> should). If not we would need yet another "ifneq
> Thanks,
> Volker

More information about the build-dev mailing list