<AWT Dev> RFR: Allow using a system installed libpng
omajid at redhat.com
Wed Feb 5 15:15:19 UTC 2014
* Andrew Hughes <gnu.andrew at redhat.com> [2014-02-04 19:26]:
> > On 2014-02-03 18:43, Omair Majid wrote:
> > > The following webrevs modify the build system to allow building against
> > > the system-installed copy of libpng as well as using the bundled copy of
> > > libpng
> > >
> > > ROOT: http://cr.openjdk.java.net/~omajid/webrevs/system-libpng/01/
> > > JDK: http://cr.openjdk.java.net/~omajid/webrevs/system-libpng/01-jdk/
> > >
> > > A new configure option `--with-libpng` is introduced which defaults to
> > > `bundled` but can be set to `system` to use the system-installed copy of
> > > libpng.
> In this respect, why does this not just use AC_ARG_ENABLE as there are only
> two options here (system libpng or bundled libpng)?
> Also, this patch hardcodes the libpng cflags and ldflags when these should
> be obtained from pkg-config. This is how these values are obtained in IcedTea
> and using this patch would thus be a regression.
The answer to both of these is the same: I followed how the existing code
handles zlib. If this needs fixing, then it needs to be fixed in the
other cases (zlib and giflib) too.
PGP Key: 66484681 (http://pgp.mit.edu/)
Fingerprint = F072 555B 0A17 3957 4E95 0056 F286 F14F 6648 4681
More information about the build-dev