code review round 0 for minor FDS makefile fix (8033714)
Daniel D. Daugherty
daniel.daugherty at oracle.com
Thu Feb 6 14:07:59 UTC 2014
On 2/5/14 9:28 PM, David Holmes wrote:
> Hi Dan,
> Looks good to me.
Thanks for the review!
> (I never run the install targets :( )
Neither do I and apparently neither does JPRT... That's how this
slipped through the cracks...
> On 6/02/2014 9:20 AM, Daniel D. Daugherty wrote:
>> This code review request is going to three different aliases.
>> Don't use Thunderbird's "reply to list" option since it will
>> pick just _one_ of the _three_ lists.
>> Doug Simon and Tom Rodriguez have sent a Full Debug Symbols (FDS)
>> makefile fix our way. Here are the bug and webrev URLs:
>> 8033714 hotspot 'install_jvm' bld target broken with
>> As you might guess from the bug synopsis, this fix is needed when
>> building without ZIP'ing the debuginfo files (ZIP_DEBUGINFO_FILES=0).
>> Based on the Graal project fix, I've updated a few other places where
>> building with FDS disabled is affected.
>> As always, comments and suggestions are welcome.
More information about the build-dev