<AWT Dev> RFR: Allow using a system installed libpng
gnu.andrew at redhat.com
Thu Feb 6 16:09:08 UTC 2014
----- Original Message -----
> * Andrew Hughes <gnu.andrew at redhat.com> [2014-02-04 19:26]:
> > > On 2014-02-03 18:43, Omair Majid wrote:
> > > > The following webrevs modify the build system to allow building against
> > > > the system-installed copy of libpng as well as using the bundled copy
> > > > of
> > > > libpng
> > > >
> > > > ROOT: http://cr.openjdk.java.net/~omajid/webrevs/system-libpng/01/
> > > > JDK: http://cr.openjdk.java.net/~omajid/webrevs/system-libpng/01-jdk/
> > > >
> > > > A new configure option `--with-libpng` is introduced which defaults to
> > > > `bundled` but can be set to `system` to use the system-installed copy
> > > > of
> > > > libpng.
> > In this respect, why does this not just use AC_ARG_ENABLE as there are only
> > two options here (system libpng or bundled libpng)?
> > Also, this patch hardcodes the libpng cflags and ldflags when these should
> > be obtained from pkg-config. This is how these values are obtained in
> > IcedTea
> > and using this patch would thus be a regression.
> The answer to both of these is the same: I followed how the existing code
> handles zlib. If this needs fixing, then it needs to be fixed in the
> other cases (zlib and giflib) too.
Yes (well, giflib doesn't have pkg-config but otherwise...). We said this last
time this work was discussed, so I'm a little surprised to see this patch being
posted in the same form again.
> PGP Key: 66484681 (http://pgp.mit.edu/)
> Fingerprint = F072 555B 0A17 3957 4E95 0056 F286 F14F 6648 4681
Free Java Software Engineer
Red Hat, Inc. (http://www.redhat.com)
PGP Key: 248BDC07 (https://keys.indymedia.org/)
Fingerprint = EC5A 1F5E C0AD 1D15 8F1F 8F91 3B96 A578 248B DC07
More information about the build-dev