RFR: JDK-8034193: Move X11 wrapper generator files to make/src and make/data

Magnus Ihse Bursie magnus.ihse.bursie at oracle.com
Tue Feb 11 13:31:46 UTC 2014

On 2014-02-11 14:25, Erik Joelsson wrote:
> On 2014-02-11 14:16, Alan Bateman wrote:
>> On 11/02/2014 13:10, Erik Joelsson wrote:
>>> Another gensrc cleanup, this time it's X11 wrappers source locations.
>>> * Moving WrapperGenerator.java to jdk/make/src/classes/...
>>> * Moving the input data files to jdk/make/data/...
>>> Bug: https://bugs.openjdk.java.net/browse/JDK-8034193
>>> Webrev: http://cr.openjdk.java.net/~erikj/8034193/webrev.jdk.01/
>> Would x11 work as the directory/package name so that it's 
>> build.tools.x11.WrapperGenerator rather than 
>> build.tools.x11wrappergenerator.WrapperGenerator?
> The pattern in jdk/make/src/classes/build/tools has so far been to 
> have one directory for describing the tool. I agree that 
> x11wrappergenerator is a bit long and we can certainly change it.

I think it's good to try to have a describing name for the package, 
since as you say, that's where the "description" have been of the tools.

What about "x11wrappergen"? And maybe shorten the class name as well, 
i.e. x11wrappergen.WrapperGen?


More information about the build-dev mailing list