RFR: JDK-8034179: Clean up nio genConstants

Alan Bateman Alan.Bateman at oracle.com
Tue Feb 11 13:53:14 UTC 2014

On 11/02/2014 11:31, Erik Joelsson wrote:
> Here is a second patch for cleaning up gensrc tools source. This time 
> it's nio related.
> * Move genUnixConstants.c, genSolarisConstants.c and 
> genSocketOptionRegistry.c to make/src/native/...
> * Rename pregenerated versions of these generated files to 
> *.java.template to avoid having to exclude them when compiling java code.
> * Move the output of the executable binaries to 
> $(JDK_OUTPUTDIR)/btnative away from the gensrc dir where we expect to 
> find java sources.
> Bug: https://bugs.openjdk.java.net/browse/JDK-8034179
> Webrev: http://cr.openjdk.java.net/~erikj/8034179/webrev.jdk.01/
This looks okay but I just wonder if it would be better to keep the ch 
(channels) and fs (file system) sub-directories so that it is clear 
which areas they are for.


More information about the build-dev mailing list