RFR: JDK-8034179: Clean up nio genConstants
erik.joelsson at oracle.com
Wed Feb 12 09:55:08 UTC 2014
New webrev: http://cr.openjdk.java.net/~erikj/8034179/webrev.jdk.02/
* Moved into fs and ch subdirectories.
* Cleaned up the logic in GensrcMisc.gmk
On 2014-02-11 14:53, Alan Bateman wrote:
> On 11/02/2014 11:31, Erik Joelsson wrote:
>> Here is a second patch for cleaning up gensrc tools source. This time
>> it's nio related.
>> * Move genUnixConstants.c, genSolarisConstants.c and
>> genSocketOptionRegistry.c to make/src/native/...
>> * Rename pregenerated versions of these generated files to
>> *.java.template to avoid having to exclude them when compiling java
>> * Move the output of the executable binaries to
>> $(JDK_OUTPUTDIR)/btnative away from the gensrc dir where we expect to
>> find java sources.
>> Bug: https://bugs.openjdk.java.net/browse/JDK-8034179
>> Webrev: http://cr.openjdk.java.net/~erikj/8034179/webrev.jdk.01/
> This looks okay but I just wonder if it would be better to keep the ch
> (channels) and fs (file system) sub-directories so that it is clear
> which areas they are for.
More information about the build-dev