RFR: JDK-8034769: Move logutil in corba to make/tools

Alan Bateman Alan.Bateman at oracle.com
Wed Feb 12 11:58:17 UTC 2014

On 12/02/2014 10:42, Erik Joelsson wrote:
> Here is another source location cleanup, this time in the corba repo. 
> The 6 classes in com/sun/tools/corba/se/logutil are only used as a 
> build tool during compilation of the corba repo. These files should be 
> moved to the corba/make/tools/src directory so that it's not confused 
> with product code.
> Bug: https://bugs.openjdk.java.net/browse/JDK-8034769
> Webrev: http://cr.openjdk.java.net/~erikj/8034769/webrev.corba.01/
This looks okay to me. Just one comment (it's really a question) is 
whether this is consistent with the jdk repository. In the jdk 
repository then the location is make/src/classes.

In passing I see the DELETES value in GensrcCorba.gmk is huge and I 
wonder why it wasn't split over multiple lines. It makes side-by-side 
diffs difficult.


More information about the build-dev mailing list