RFR: JDK-8034199 Add 'reconfigure' target for re-creating a configuration

Tim Bell tim.bell at oracle.com
Thu Feb 13 15:34:19 UTC 2014

Hi Magnus:

Looks good to me as well.


On 02/13/14 02:30 AM, Erik Joelsson wrote:
> Looks even better to me.
> /Erik
> On 2014-02-12 23:31, Magnus Ihse Bursie wrote:
>> On 2014-02-12 19:19, Martin Buchholz wrote:
>>> I'm not sure exactly what the problem is, but do you need a 
>>> contribution
>>> like this:
>> Yeah, something like that. :-) Thanks! I knew something like that was 
>> needed, but I did not feel like writing it.
>> I took your snipped and adapted it slightly, to improve readability 
>> for common cases. E.g. if you call --with-extra-cflags="-DFOO -DBAR" 
>> it will store it as --with-extra-cflags='-DFOO -DBAR' rather than 
>> '--with-extra-cflags=-DFOO -DBAR'. They both evaluate to the same 
>> result, but the former is -- to me, at least, more easy to read and 
>> more likely to match what the user initially wrote.
>> This interception needs to happen early, in the configure wrapper.
>> I've tried to make this break with various evil combinations, but 
>> failed, so I think it's fairly robust. (And once again I really miss 
>> that I can't turn such adhoc testing into proper tests. :-( )
>> Here's a new webrev: 
>> http://cr.openjdk.java.net/~ihse/JDK-8034199-add-reconfigure-target/webrev.02
>> /Magnus

More information about the build-dev mailing list