8032443: ,Java Access Bridge version strings need to be fixed
peter.brunet at oracle.com
Mon Feb 24 19:55:12 UTC 2014
Hi Magnus, Thanks very much for looking at this.
On 2/19/14 3:55 AM, Magnus Ihse Bursie wrote:
> On 2014-02-18 05:22, Pete Brunet wrote:
>> Please review this change:
>> for this bug:
>> Some resource compiler defines are need so the JAB DLLs Properties sheet
>> will have the proper information. This change fixes the names that are
> Even though I don't know how these RC flags are interpreted, I notice
> that virtually all other libraries that has a JDK_FNAME and
> JDK_INTERNAL_NAME also has a JDK_FTYPE=0x2L.
The FILETYPE 0x02 is
VFT_DLL File contains a dynamic-link library (DLL).
It's defined in winver.h.
> (In fact, generalizing the pattern
> RC_FLAGS := $(RC_FLAGS) \
> -D "JDK_FNAME=FOO.dll" \
> -D "JDK_INTERNAL_NAME=FOO" \
> -D "JDK_FTYPE=0x2L",
> that appear all over the place is something that has been on our
> agenda, unfortunately for far too long without happening).
> It seems that there need to be a good reason for these libraries to
> not match this pattern.
In my case the 0x02 is defined in the RC file, but I'll change the patch
to match what you describe above.
More information about the build-dev