RFR 6997010: Consolidate java.security files into one file with modifications

Wang Weijun weijun.wang at oracle.com
Fri Jul 25 14:44:42 UTC 2014

On Jul 25, 2014, at 22:30, Sean Mullan <sean.mullan at oracle.com> wrote:

>> http://cr.openjdk.java.net/~weijun/6997010/webrev.00/
>> 4. *IMPORTANT*: In order to easily maintain platform-related entries,
>> every line (including the last line) in package.access and
>> package.definition MUST end with ',\' now. A blank line MUST exist
>> after the last line. This avoid ugly lines like
>> #ifndef windows entry1. #endif #ifdef windows entry1.,\ entry2
>> #endif
> What happens if someone (inevitably) adds a new package to the list and forgets to do either of these? Does it result in a build failure?

No build failure, but test/java/security/SecurityManager/CheckPackageAccess.java will fail.

I can add check in the build tool.

> Otherwise looks good, although I think it would be useful to write an additional test to make sure the correct providers are installed and ordered correctly on the different platforms, something similar to the java/lang/SecurityManager/CheckPackageAccess.java test but specific to providers.



More information about the build-dev mailing list