RFR(XS): 8054009: Support SKIP_BOOT_CYCLE=false when invoked from JPRT
erik.joelsson at oracle.com
Thu Jul 31 06:54:17 UTC 2014
Looks good to me, except that the body of the conditional should be
indented by 2 spaces.
On 2014-07-31 04:12, Mikael Vidstedt wrote:
> Please review the following small fix which re-introduces support for
> the SKIP_BOOT_CYCLE=false option when the build is invoked from JPRT.
> The support for doing the bootcycle build was accidentally lost when
> the change was made to have jprt run configure. The fix simply adds
> a conditional dependency on the the bootcycle target when
> SKIP_BOOT_CYCLE=false is been specified.
> Bug: https://bugs.openjdk.java.net/browse/JDK-8054009
> Webrev (jdk9/dev):
> This will also need to be backported to jdk8u/jdk8u-dev, so here's the
> "optimistic" backport:
> Webrev (jdk8u/jdk8u-dev):
>  https://bugs.openjdk.java.net/browse/JDK-8029797
More information about the build-dev