RFR: [9] 8043340 & 8043591: [macosx] Build system issues

David DeHaven david.dehaven at oracle.com
Thu Jun 5 14:39:45 UTC 2014

> Only thing I can think of now is that some of the error/warning messages do not start with a capital letter. Looks good and nice work!

I'll fix those before pushing.

>> I also removed using SDKROOT from the env, since we ignore the environment. Only two args affect SYSROOT now, --with-sysroot and --with-sdk-name.
> I think that's good too, I had some doubts about that. Is that environment variable set by the system in some way or is it something one sets manually? If it's something the system sets, then perhaps it's worth looking at (compare VS100COMNTOOLS on windows which points to visual studio). But since we can get the information from xcodebuild anyway, it really doesn't matter.

Right. SDKROOT is set when Xcode is building, so it would either be set by the user or if someone were building OpenJDK as part of an Xcode project.

> Nice to see a speedup in building too. The broken case seems ok to me. Not much we can do there. Silently switching to clang would be bad too.



More information about the build-dev mailing list