RFR 8037825 Fix warnings and enable "warnings as errors" in serviceability native libraries

Alan Bateman Alan.Bateman at oracle.com
Thu Mar 20 10:25:53 UTC 2014

On 20/03/2014 09:13, Staffan Larsen wrote:
> Thanks!
> Still need someone to look at the actual code changes.
In webrev.01 then jdk/make/lib/ServiceabilityLibraries.gmk and 
src/solaris/native/sun/management/MacosxOperatingSystem.c are showing up 
as new files, I can't tell why that is.

The code changes mostly look good to me. The only change that isn't very 
clear (I had to stare at it for a few minutes) in log_messages.c where 
it's now two calls to strftime. It might be useful to include a comment 
to explain this, also maybe reduce the line length to make it easier for 
future side-by-side reviews.


More information about the build-dev mailing list