RFR: 8030681 : (s) add "serve" command and --quiet and --verbose options to hgforest

Magnus Ihse Bursie magnus.ihse.bursie at oracle.com
Mon Mar 24 10:18:09 UTC 2014

On 2014-03-20 17:39, Mike Duigou wrote:

>> I found this:
>> # XXX mduigou I can't figure out how to make the root repo the serve "/" root.
>> Is this something that ought to be fixed?
> I wish I knew how. Despite fiddling with it extensively I was unable to convince hg to serve the top repo from
> http://server:8000/
> instead the top repo is:
> http://server:8000/<top-repo>
> I wanted to have the URL of the top repo displayed as part of the serve message but a) can't get hg to display it b) can't determine what the service address is going to be myself to construct the url.
> It's a minor annoyance/limitation that people will get used to.

It was a bit unclear to me until I tested running it myself. I see what 
you mean. But I think this is completely acceptable. I'd recommend you 
leave the functionality as it is and just removes the comment.

Apart from that, the fix looks good to me.


More information about the build-dev mailing list