RFR: JDK-8035751 Clean up Visual Studio detection logic

Magnus Ihse Bursie magnus.ihse.bursie at oracle.com
Mon Mar 24 12:52:21 UTC 2014

On 2014-03-24 12:20, Erik Joelsson wrote:
> I think it looks good overall and it's good to clean this up.
> toolchain_windows.m4:
> 204: not your change but the typo stings my eyes and could be fixed 
> while in the area. (corrent?)

> I wonder if it would be better to move the deletion of the temporary 
> script files to later in the function so that they are still around if 
> it fails, for easier debugging?

Actually, there's no real need to delete the files at all. I commented 
out the removal during debugging of this patch at several occasions. We 
should just keep them around, if we need to debug them. I've modified 
the script to put them in "OUTPUT/vs-env" and keep them there.

I also realized the names I chose didn't match our naming standard (_ 
instead of - as separator). I fixed this as well. Updated webrev:



More information about the build-dev mailing list