RFR: JDK-8058631 Rename posix to unix in build system to match file name changes

Volker Simonis volker.simonis at gmail.com
Wed Nov 5 16:13:42 UTC 2014

Hi Magnus,

I've looked at the change and I think it looks good.
For any case I've also run an AIX build with your change applied and
didn't encounter any problems.
So thumbs up from me!


PS: how did you produce a webrev from two repositories - do you have a
special version of webrev?
And what's the best way to import such a change into mercurial (apart
from 'patch'). I manually edited the patch file to make 'compatible'
with 'qimport' but maybe there's a better way?

On Wed, Nov 5, 2014 at 2:04 PM, Magnus Ihse Bursie
<magnus.ihse.bursie at oracle.com> wrote:
> On 2014-09-24 14:39, Magnus Ihse Bursie wrote:
>> After Jigsaw M1, there is a new common "unix" directory structure. We have
>> used "posix" in the build system for the same purpose, but this leads to
>> unnecessary conversations. Instead, we should use "unix" all way through in
>> the build system.
>> Also, this means that OS_API is slightly misleading -- we're not actually
>> checking for an API such as POSIX, but the general category of OSes. I'll
>> rename the *_OS_API to *_OS_TYPE instead. The "winapi" OS_API was never
>> used, and is removed -- we only need to check for "windows", there's no need
>> to introduce an abstract "winapi" category.
>> Bug: https://bugs.openjdk.java.net/browse/JDK-8058631
>> WebRev:
>> http://cr.openjdk.java.net/~ihse/JDK-8058631-rename-posix-to-unix/webrev.01
> This fix got stuck far down the priority list...
> It was pointed out to me that OS_API_SRC_DIRS should change name as well, to
> match OS_TYPE. This updated webrev contain that fix. I have also
> double-checked that no other name changes are needed to keep the code
> consistent.
> Updated webrev:
> http://cr.openjdk.java.net/~ihse/JDK-8058631-rename-posix-to-unix/webrev.02/
> /Magnus

More information about the build-dev mailing list