RFR: AARCH64: Top-level JDK changes

Volker Simonis volker.simonis at gmail.com
Fri Nov 7 18:00:37 UTC 2014

The changes look good besides the ones to common/autoconf/build-aux/config.sub

When we did our initial check-in there have been objections to modify
autoconf-config.guess because that one was "copied directly from the
autoconf project and should not be modified". I think the same applies
to config.sub as well.

But on the other side, we have an OpenJDK specific wrapper for
autoconf-config.guess (i.e. config.guess) but there's no such wrapper
for config.sub where we could fix-up things.

So we have three possibilities:

1. make your change as suggested (which breaks the rule of not editing
upstream files)
2. create a wrapper for config.sub, i.e. move config.sub to
autoconf-config.sub and call it from config.sub which can contain
arbitrary fix-up coding (which seems a little over-engineered IMHO)
3. pull in the new version of config.guess and config.sub from [1]
which already seem to have the changes you need.

I'm all in favour of point three which would also allow us to get rid
of some of the hacks which are currently in config.guess. And now, as
we're still early in the jdk9 development the risk of doing this seems
minimal, but let's see what the build-dev guy say?


[1] http://git.savannah.gnu.org/gitweb/?p=config.git;a=blob_plain;f=config.guess;hb=HEAD

On Fri, Nov 7, 2014 at 6:34 PM, Vladimir Kozlov
<vladimir.kozlov at oracle.com> wrote:
> CCing to build-dev and JDK9-dev since it is top level changes.
> Note, it will go into staging aarch64 repo.
> Vladimir
> On 11/7/14 9:21 AM, Andrew Haley wrote:
>> The first patch: top-level build machinery changes.
>> http://cr.openjdk.java.net/~aph/8064357-rev-1/
>> Andrew.

More information about the build-dev mailing list