RFR: AARCH64: Top-level JDK changes
Magnus Ihse Bursie
magnus.ihse.bursie at oracle.com
Thu Nov 13 14:03:00 UTC 2014
On 2014-11-10 18:45, Omair Majid wrote:
> * Christian Thalinger <christian.thalinger at oracle.com> [2014-11-07 13:11]:
>>> On Nov 7, 2014, at 9:55 AM, Andrew Haley <aph at redhat.com> wrote:
>>> On 11/07/2014 05:42 PM, Christian Thalinger wrote:
>>>> + aarch64)
>>>> + ZERO_ARCHFLAG=""
>>>> + ;;
>>>> Why is this required on aarch64 but not all the other architectures?
>>> I think it's because GCC rejects "-m64”.
>> That’s interesting. I thought -m<archbits> is some kind of common
>> flag that works on all architectures. Can someone verify this?
> I had to do a similar fix for zero on arm32:
> Perhaps that can be re-used here?
That's a good point. $COMPILER_TARGET_BITS_FLAG is used in several
places. All of them ought to be guarded by tests on
$COMPILER_SUPPORTS_TARGET_BITS_FLAG, but I don't think they are. But
this sounds like such a situation -- what we should be testing for is
not so much the platform as if $COMPILER_TARGET_BITS_FLAG is supported.
More information about the build-dev