RFR: AARCH64: 8064357: Top-level JDK changes

Dean Long dean.long at oracle.com
Fri Nov 21 19:31:08 UTC 2014

One minor comment:  do we want to preserve the history in the new 
or check it in as a new file?


On 11/21/2014 10:03 AM, Magnus Ihse Bursie wrote:
> On 2014-11-21 18:02, Andrew Haley wrote:
>> On 11/21/2014 03:46 PM, Magnus Ihse Bursie wrote:
>>> 1) Comment in config.sub identifies it as config.guess.
>>> 2) As as understand it, your first attempt is to just dispatch through
>>> to autoconf-config.sub if there is no aarch64 arguments. Good! However,
>>> the code could be made clearer: The dot is small and some comment
>>> clarifying that we will exit after this line might be helpful to the
>>> reader. Also, you're using a $sub_args which is not defined. This will
>>> not break, but it makes the reader confused. (I suspect copy/paste 
>>> glitch.)
>>> 3) The webrev indicates that the original config.sub was renamed to
>>> config.sub.orig, instead of autoconf-config.sub. But since that is how
>>> it is called in the new config.sub wrapper, the patch is unlikely to
>>> work. When you test this, make sure you have no lingering files in your
>>> workspace that can mess up the results. (e.g. no "?" files in hg 
>>> status).
>> http://cr.openjdk.java.net/~aph/aarch64-8064357-5/
> Looks good to me.
> Thanks for working through all these iterations!
> /Magnus

More information about the build-dev mailing list