RFR: JDK-8027627 LOG=trace hardcodes value to bash

Magnus Ihse Bursie magnus.ihse.bursie at oracle.com
Wed Sep 3 08:35:22 UTC 2014

On 2014-09-02 22:19, Jonathan Gibbons wrote:
> There were two occurrences of /bin/bash on that line, but only one was 
> changed. Was that intentional?

No, it most definitely wasn't. Thank you for your keen eyes!

Follow-up bug: https://bugs.openjdk.java.net/browse/JDK-8057125

Patch inline:
diff --git a/make/common/MakeBase.gmk b/make/common/MakeBase.gmk
--- a/make/common/MakeBase.gmk
+++ b/make/common/MakeBase.gmk
@@ -349,7 +349,7 @@
      # (and causing a crash on Cygwin).
      # Default shell seems to always be /bin/sh. Must override with 
bash to get this to work on Solaris.
      # Only use time if it's GNU time which supports format and output 
-    WRAPPER_SHELL:=$$(BASH) $$(SRC_ROOT)/common/bin/shell-tracer.sh 
$$(if $$(findstring yes,$$(IS_GNU_TIME)),$$(TIME),-) 
$$(OUTPUT_ROOT)/build-trace-time.log /bin/bash
+    WRAPPER_SHELL:=$$(BASH) $$(SRC_ROOT)/common/bin/shell-tracer.sh 
$$(if $$(findstring yes,$$(IS_GNU_TIME)),$$(TIME),-) 
$$(OUTPUT_ROOT)/build-trace-time.log $$(BASH)
      SHELL=$$(warning $$(if $$@,Building $$@,Running shell command) 
$$(if $$<, (from $$<))$$(if $$?, ($$(wordlist 1, 20, $$?) $$(if 
$$(wordlist 21, 22, $$?), ... [in total $$(words $$?) files]) 
    # Never remove warning messages; this is just for completeness


More information about the build-dev mailing list