RFR 8039898: sunpkcs11-solaris.cfg should be in solaris specific directory

Magnus Ihse Bursie magnus.ihse.bursie at oracle.com
Thu Sep 11 10:42:42 UTC 2014

On 2014-09-11 11:51, Alan Bateman wrote:
> On 11/09/2014 10:38, Magnus Ihse Bursie wrote:
>> The webrev shows the file as being moved outside the control of 
>> mercurial. That is, if you do "hg mv" to move the file, the history 
>> of the file will be kept intact. Otherwise it will look like a new 
>> file in the repo. (Sometimes this doesn't show up properly in the 
>> webrev, apologies if you already did this.)
> For webrev then I think it depends on whether the changes have been 
> committed or not. If you do a hg mv and then webrev -N before 
> committing then it will show as a move. If you commit and then 
> generate the webrev then it looks like a delete + new file. Maybe 
> there is an opportunity for someone to see if webrev can be made a bit 
> smarter.
Aha, that's the reason. I know it "usually" work but not always, but I 
have not seen the pattern. (I usually create pre-checkin webrevs.)


More information about the build-dev mailing list