RFR: JDK-8058118: Generate modules.list during the build
Alan.Bateman at oracle.com
Sun Sep 14 13:45:44 UTC 2014
On 13/09/2014 09:30, Chris Hegarty wrote:
> Update jdk part as per Mandy’s comments:
I looked through the update and it looks good.
A minor comment for both ModulesXmlReader and ModulesXmlWriter is that a
private no-arg constructor would make it a bit clearer they should be
used via the static methods. For a better symmetry between the two
classes then you could rename modules to readModules.
I also skimmed over the top-level repo in Erik's original webrev and I
don't see anything wrong.
More information about the build-dev