RFR: JDK-8058118: Generate modules.list during the build

Magnus Ihse Bursie magnus.ihse.bursie at oracle.com
Mon Sep 15 11:00:25 UTC 2014

On 2014-09-15 12:32, Erik Joelsson wrote:
> Hello,
> New webrevs with Chris' latest fixes and a few small modifications to 
> makefiles. I removed some of the extra -I flags in Makefile and used 
> the variable for all references to modules.list in Modules.gmk.
> http://cr.openjdk.java.net/~erikj/8058118/webrev.root.02/
> http://cr.openjdk.java.net/~erikj/8058118/webrev.jdk.02/

I have looked at the build changes only, not the Java tool.

It looks good to me, apart from the name of the new build directory. 
Could you please rename it "make-support" with a hyphen, the 
"makesupport" looked so clumsy. You don't need to create a new review 
for that.


> /Erik
> On 2014-09-12 16:03, Erik Joelsson wrote:
>> Hello,
>> The checked in modules.list file defines the dependencies between 
>> modules for the build. The dependency information in this file is 
>> already captured in the modules.xml. Rather than keeping two copies 
>> of this information, with this change, modules.list is generated 
>> during the build.
>> Chris provided the java implementation for the actual list 
>> generation. I've made the makefile changes.
>> Bug: https://bugs.openjdk.java.net/browse/JDK-8058118
>> Webrevs: http://cr.openjdk.java.net/~erikj/8058118/
>> /Erik

More information about the build-dev mailing list