Review request JDK-8058367: Add verify-modules target to the default and images target
Magnus Ihse Bursie
magnus.ihse.bursie at oracle.com
Mon Sep 15 11:29:07 UTC 2014
On 2014-09-15 11:48, Erik Joelsson wrote:
>> I'm less sure about changing the default target as it adds a few
>> additional seconds. I wonder if this part should be left out on the
>> assumption that most people are likely to make sure that images build
>> before they push.
> I would agree with Alan that adding it to images would likely be enough.
I agree as well. :) On my system, a clean rebuild (with no changes) goes
from rougly 1 second to 16-17 seconds (!), just by verifying the images,
with this change.
Apart from that, the fix looks good.
More information about the build-dev