Review request JDK-8058367: Add verify-modules target to the default and images target
philip.race at oracle.com
Mon Sep 15 15:57:22 UTC 2014
My assumption is the opposite, that most people type 'make' and
nothing more, expecting that if you had to do more to test a code
change builds properly, it would be included in the default target.
If you aren't affecting the images, then you don't expect to need
to build the images.
On 9/15/2014 2:48 AM, Erik Joelsson wrote:
> On 2014-09-13 10:05, Alan Bateman wrote:
>> On 12/09/2014 21:48, Mandy Chung wrote:
>>> With the Modular Source Code  in JDK 9, the verify-modules target
>>> was added in the build to catch any regression to the module
>>> It's important to catch this regression early during jdk development.
>>> This patch proposes to add verify-modules to the default target
>>> and also images target (it was a bug). This will track the time
>>> to determine if the build time becomes an issue.
>>> Webrev at:
>> I assumed that the images target already ran verify-modules, it seems
>> not. That part looks good to me.
>> I'm less sure about changing the default target as it adds a few
>> additional seconds. I wonder if this part should be left out on the
>> assumption that most people are likely to make sure that images build
>> before they push.
> I would agree with Alan that adding it to images would likely be enough.
More information about the build-dev