Review request JDK-8058367: Add verify-modules target to the default and images target

Mandy Chung mandy.chung at
Mon Sep 15 18:46:52 UTC 2014

On 9/15/14 10:36 AM, Alan Bateman wrote:
> On 15/09/2014 18:24, Mandy Chung wrote:
>> I am starting to not to count on most people building images and
>> inclined to catch any new dependence earlier in the default build
>> to avoid potential build breakage.
>> The time for verify-modules is not small and there is potential
>> performance improvement. I suspect people may use JDK_FILTER,
>> or sjavac to get fast incremental build time.  Perhaps we could
>> provide a flag to disable verify-modules if they really want
>> fast build time.
>> Mandy
> I think there is enough continuous build bots and people building 
> images that any breakage will be found very quickly. Maybe we should 
> just start with images and see how it goes, we can always add it to 
> the default target if it turns out to be a regular occurrence.

I can go with that and see how it goes.  The continuous build was what I 
started looking at and realized that the verify-modules is missing the 
images build.   We should get this fixed soon and evaluate the default 
target next.


More information about the build-dev mailing list