Review request JDK-8058367: Add verify-modules target to the default and images target
david.holmes at oracle.com
Tue Sep 16 02:04:28 UTC 2014
On 16/09/2014 4:46 AM, Mandy Chung wrote:
> On 9/15/14 10:36 AM, Alan Bateman wrote:
>> On 15/09/2014 18:24, Mandy Chung wrote:
>>> I am starting to not to count on most people building images and
>>> inclined to catch any new dependence earlier in the default build
>>> to avoid potential build breakage.
>>> The time for verify-modules is not small and there is potential
>>> performance improvement. I suspect people may use JDK_FILTER,
>>> or sjavac to get fast incremental build time. Perhaps we could
>>> provide a flag to disable verify-modules if they really want
>>> fast build time.
>> I think there is enough continuous build bots and people building
>> images that any breakage will be found very quickly. Maybe we should
>> just start with images and see how it goes, we can always add it to
>> the default target if it turns out to be a regular occurrence.
> I can go with that and see how it goes. The continuous build was what I
> started looking at and realized that the verify-modules is missing the
> images build. We should get this fixed soon and evaluate the default
> target next.
At what point, if any, is javac armed with the dependency information so
that it can report any incorrect cross-module references (as we did for
Compact Profiles) ?
More information about the build-dev