RFR 8042901: Allow com.sun.management to be in a different module to java.lang.management
erik.joelsson at oracle.com
Wed Apr 1 07:56:35 UTC 2015
(Adding build-dev since this touches makefiles and jigsaw-dev since this
In general, the build changes look pretty good. I much appreciate moving
the OS specific source into OS specific source dirs. A few notes
however. Though I realize you followed existing patterns, we have some
more current best practices that I would like to incorporate in new code.
The variables BUILD_LIBJDKMANAGEMENT_SRC and
BUILD_LIBJDKMANAGEMENT_CFLAGS should lose the "BUILD_" prefix. While it
works, it makes them unnecessarily long and it risks conflicting with
internal variables created in the SetupNativeCompilation call.
BUILD_LIBJDKMANAGEMENT_EXCLUDES is unused and should just be removed.
The EXCLUDE_FILES parameter too.
LIBJDKMANAGEMENT_MAPFILE should be removed. This was a special construct
for libmanagement used for a while until cmm was split into a separate
module. Just inline the mapfile line into the macro call.
BUILD_LIBMANAGEMENT_EXCLUDES is unused here as well.
LIBMANAGEMENT_MAPFILE should be inlined here as well.
While you are at it, might as well fix the BUILD_ prefix on the SRC and
CFLAGS variables here too if you don't mind.
Is the need for low optimization when debug symbols are active still
valid for both libmanagement and libmanagement_ext?
On 2015-03-31 18:39, shanliang wrote:
> Please review this fix:
> Bug: https://bugs.openjdk.java.net/browse/JDK-8042901
> Webrev: http://cr.openjdk.java.net/~sjiang/JDK-8042901/00/
> Some code within the module java.management is separated and moved to
> the new module jdk.management, the new module takes the implementation
> code for Oracle Corporation's platform extension to the implementation
> of the java.lang.management API and also the management interface for
> some other components for the platform.
More information about the build-dev