RFR: JDK-8077824: Introduce DefineNativeToolchain to handle toolchain configurations
Magnus Ihse Bursie
magnus.ihse.bursie at oracle.com
Thu Apr 16 12:12:09 UTC 2015
On 2015-04-16 12:01, Erik Joelsson wrote:
> New webrev: http://cr.openjdk.java.net/~erikj/8077824/webrev.root.02/
Looks good to me now! Just one typo: "assignements", no need to respin
the webrev for that.
>> * BUILD_LIBJAWT seems to have lost a LANG := C++ but not gained a
>> TOOLCHAIN := TOOLCHAIN_LINK_CXX. The same goes for LIBAWT_LANG,
>> BUILD_LIBSUNMSCAPI, BUILD_LIBJSOUNDDS and the accessbridge stuff in
>> Is there some reason that the change here does not change the
>> resulting link behavior? Or is this an oversight?
> This is on purpose. The Windows only libraries link the same way
> regardless of C or C++ so no need to add special configuration for them.
I realized that later. Good riddance! :)
More information about the build-dev