Fwd: Re: RFR(xxs): 8072935: Fix missing newline at end of file after 8067447
david.holmes at oracle.com
Fri Feb 13 11:18:09 UTC 2015
On 13/02/2015 9:08 PM, Volker Simonis wrote:
> Hi David,
> Thomas' initial change which started this discussion, i.e.
> adds the missing newline to src/share/vm/services/writeableFlags.cpp.
> It should be pushed to jdk9-hs-rt/ (preferably before jdk9-hs-rt gets
> pushd to jdk9-hs and jdk9-dev).
> For this we need a sponsor. Maybe you can volunteer:)
This thread isn't about that actual fix. This was about minimal gcc
version and now also possible jcheck change.
> Independently of this fix I've suggested to add a check for missing
> newline at the end of file to jcheck. I've meanwhile opend a
> corresponding bug and submitted a patch for review to the
> code-tools-dev list:
> But again, this will only prevent such errors in the future. The
> current file which has no newline at the end has to be fixed with
> Thomas' patch.
> On Fri, Feb 13, 2015 at 11:09 AM, David Holmes <david.holmes at oracle.com> wrote:
>> On 13/02/2015 7:23 PM, Volker Simonis wrote:
>>> could somebody please sponsor and push this change.
>> Push it to where, as what? I thought you wanted a jcheck addition.
>>> On Fri, Feb 13, 2015 at 7:49 AM, Martin Buchholz <martinrb at google.com>
>>>> Source files should have exactly one trailing newline.
>>>> find -iregex '.*\.\(java\|txt\|c\|cc\|h\|hpp\|cpp\)$' | xargs perl -0777
>>>> 'print "Must have exactly one trailing newline: $ARGV\n" unless
More information about the build-dev