RFR: JDK-8072842 Add support for building native JTReg tests

Magnus Ihse Bursie magnus.ihse.bursie at oracle.com
Fri Feb 27 09:49:04 UTC 2015

On 2015-02-27 10:43, Magnus Ihse Bursie wrote:
> On 2015-02-26 10:25, Erik Joelsson wrote:
>> Hello Magnus,
>> Overall looks good. I would prefer if some of the longer lines in 
>> Main.gmk were split as it's a file I often need to read. In MakeBase, 
>> the definition of dups, I thought we (informally) agreed to start 
>> such macro definitions with a newline to make them stand out more 
>> from normal variable declarations?
> I had forgot about that; I just copied the pattern of the macros that 
> was already in place.
> I have now updated dups to use the newline format. I also updated the 
> old macros to follow this rule.
> All the new lines in MakeBase should now be shorter than 80 chars.
... and I added the missing targets test-*-jtreg-native to ALL_TARGETS.

> New webrev: 
> http://cr.openjdk.java.net/~ihse/JDK-8072842-build-native-jtreg-tests/webrev.03
> /Magnus

More information about the build-dev mailing list