[PATCH] Fix Shark build in JDK9

Volker Simonis volker.simonis at gmail.com
Wed Jan 7 17:00:39 UTC 2015

On Wed, Jan 7, 2015 at 5:29 PM, Roman Kennke <rkennke at redhat.com> wrote:
> Am Mittwoch, den 07.01.2015 um 17:16 +0100 schrieb Erik Joelsson:
>> On 2015-01-07 17:11, Roman Kennke wrote:
>> > Hi Erik,
>> >
>> > Do you have a bug for this?
>> > No.
>> >
>> > I haven't pushed any changes to JDK in a while. Is it possible in the
>> > meantime for me to create my own bugs? Otherwise, please file one for
>> > me :-)
>> You should be able to log in to https://bugs.openjdk.java.net and create
>> bugs since you have an OpenJDK identity.
> Done:
> https://bugs.openjdk.java.net/browse/JDK-8068598
> While I'm at it, is it possible for me to push my own changes (except
> hotspot of course)?

Hi Roman,

in order to push changes you first have to be a committer (which you are).

As you noticed, external (i.e. external to Oracle) committers can not
push changes to the hotspot repository with the exception of changes
which only touch community-supported platform files (i.e. all files
under src/cpu/{ppc, zero}, src/os/aix, ...)

Besides that you should be technically able to push changes to all
other repositories but you shouldn't do that for changes which require
changes in the closed source files Oracle maintains in parallel to the
OpenJDK sources. These are for example all the files which require the
regeneration of the generated configure script.

Depending on your time constraints it may be reasonable to ask Erik to
push your top-level/jdk changes right into the corresponding hotspot
forest in which you want to do your hotspot changes. Otherwise, if
your top-level/jdk changes are pushed to jdk9/dev it may take up to
two weeks until they arrive for example in jdk9/hs-rt.


PS: by the way, the changes themselves look fine to me:)

> If yes, what needs to be done for regenerating the
> configure files? Simply run autogen.sh in common/autoconf with whatever
> version of autotools I have? Or doesn't it make sense at all b/c you
> need to regenerate your closed scripts?
> Roman

More information about the build-dev mailing list